Fix ComparisonFailure constructor compatibility with sebastian/comparator v8#670
Closed
jorgsowa wants to merge 2 commits into
Closed
Fix ComparisonFailure constructor compatibility with sebastian/comparator v8#670jorgsowa wants to merge 2 commits into
jorgsowa wants to merge 2 commits into
Conversation
…ator v8 sebastian/comparator < 5 has a 6-param constructor with $identical (bool) as 5th param, while >= 8 also has 6 params but with $contextLines (int) as 6th param. The previous check only looked at parameter count (>= 6), causing wrong types to be passed on v8. Now also checks the parameter name to distinguish the two signatures. Fixes phpspec#669
Member
|
Closing this in favor of #671 in which I implemented a better fix, to actually support the new feature of |
Author
|
Thanks! I think that workaround for sebastian/comparator < 5 may be even removed from the code. I didn't think about it previously. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sebastian/comparator< 5 has a 6-param constructor with $identical (bool) as 5th param, while >= 8 also has 6 params but with $contextLines (int) as 6th param. The previous check only looked at parameter count (>= 6), causing wrong types to be passed on v8. Now also checks the parameter name to distinguish the two signatures.Fixes #669