Skip to content

Select correct box from hierarchy when importing #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pm-phild wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Select correct box from hierarchy when importing #84

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8b14db
Added ASCII85 decode support
Oct 3, 2025
f2c110b
Revert "Added ASCII85 decode support"
Apr 8, 2026
2ad9516
Merge branch 'phpdave11:master' into master
pm-phild Apr 16, 2026
db351cc
Select correct box from hierarchy
May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,22 @@ func (this *PdfWriter) ClearImportedObjects() {
this.written_objs = make(map[*PdfObjectId][]byte, 0)
}

func getValidBoxName(boxes map[string]map[string]float64, name string) string {
if bm, ok := boxes[name]; !ok || len(bm) == 0 {
switch name {
case "/ArtBox":
return getValidBoxName(boxes, "/TrimBox")
case "/TrimBox":
return getValidBoxName(boxes, "/BleedBox")
case "/BleedBox":
return getValidBoxName(boxes, "/CropBox")
case "/CropBox":
return "/MediaBox"
}
}
return name
}

// Create a PdfTemplate object from a page number (e.g. 1) and a boxName (e.g. MediaBox)
func (this *PdfWriter) ImportPage(reader *PdfReader, pageno int, boxName string) (int, error) {
var err error
Expand All @@ -129,13 +145,7 @@ func (this *PdfWriter) ImportPage(reader *PdfReader, pageno int, boxName string)
}

// If requested box name does not exist for this page, use an alternate box
if _, ok := pageBoxes[boxName]; !ok {
if boxName == "/BleedBox" || boxName == "/TrimBox" || boxName == "ArtBox" {
boxName = "/CropBox"
} else if boxName == "/CropBox" {
boxName = "/MediaBox"
}
}
boxName = getValidBoxName(pageBoxes, boxName)

// If the requested box name or an alternate box name cannot be found, trigger an error
// TODO: Improve error handling
Expand Down