Preserve each user's push token#129
Open
iMattPro wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a new post is made, notify() loops through the queue which contains one notification object per user — e.g. users 2, 3, 4, 5, 6 all watching topic 1. Each gets their own DB row with their own unique push_token (generated from random_bytes(32)).
With the old two-key map [type_id][item_id], each iteration overwrote the same slot:
Then notify_using_webpush() built every user's push payload using token_for_user_6's hash. When users 2–5's service workers tried to fetch the notification, the controller computed hash(user_form_salt . push_token) from the DB — which wouldn't match the token in the payload — and returned NO_AUTH_OPERATION.
The three-key map [type_id][item_id][user_id] preserves each user's token independently, so each push payload carries the correct hash for that specific user.