Change array syntax to more commonly used#269
Closed
kkmuffme wants to merge 1 commit into
Closed
Conversation
kkmuffme
commented
Dec 7, 2025
kkmuffme
commented
- to visually distinguish from conditional types like ($foo ? false : string[]) and callable syntax
- to improve readability for array shapes and arrays of literals
- to visually more closely align it with PHP native type hint
* to visually distinguish from conditional types like ($foo ? false : string[]) and callable syntax * to improve readability for array shapes and arrays of literals * to visually more closely align it with PHP native type hint
mspirkov
reviewed
Dec 7, 2025
mspirkov
left a comment
mspirkov
left a comment
Contributor
There was a problem hiding this comment.
The tests need to be completed/corrected.
Author
|
Can you please approve the github workflow, so they run in github's CI so I know what/which if any fail, bc if I run all projects' tests locally I can't work on something else in the meantime |
Contributor
|
No, I don't have access. We'll have to wait for @jaapio for that. |
Member
|
Also this PR needs tests. Test coverage has never been 100% but we need to make sure we are not breaking things in the future. |
Contributor
|
I suggest doing it like this: #274 |
Contributor
|
I think this request can be closed because I did it in another request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.