Skip to content

Add support for properties-of and its variations#267

Merged
jaapio merged 3 commits into
phpDocumentor:2.xfrom
mspirkov:add-properties-of
Dec 9, 2025
Merged

Add support for properties-of and its variations#267
jaapio merged 3 commits into
phpDocumentor:2.xfrom
mspirkov:add-properties-of

Conversation

@mspirkov

@mspirkov mspirkov commented Dec 7, 2025

Copy link
Copy Markdown
Contributor

@mspirkov mspirkov marked this pull request as ready for review December 7, 2025 06:23
@jaapio

jaapio commented Dec 8, 2025

Copy link
Copy Markdown
Member

Can you please rebase your branch?

I'm a bit in doubt about this new type. while I understand why you added this, I'm not sure it makes things more clear. The type is just used by psalm? And it kinda feels like the returned type is a dynamic array shape?

@mspirkov

mspirkov commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

Yes, I'll update the branch now.
Yes, it's a Psalm type. I think we should support Psalm syntax.

@mspirkov

mspirkov commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

As far as I understand, the return type is an array of the form array<string, mixed>

@jaapio jaapio merged commit ace4950 into phpDocumentor:2.x Dec 9, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants