Fix memory leak when a plain parameter repeats an RFC2231 name#66
Closed
iliaal wants to merge 1 commit into
Closed
Fix memory leak when a plain parameter repeats an RFC2231 name#66iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #71, reopened from the fork (iliaal/pecl-mail-mailparse). Branch should not have been pushed to php/ directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A plain MIME parameter whose name matches an active RFC2231 continuation leaks the parameter-name string. The leak size is the attacker-controlled name length and it repeats per occurrence, so a crafted header stream is a slow memory-exhaustion vector.
Example:
Content-Type: text/plain; URL*0="a"; URL="b". TheURL="b"parameter shares the base name of theURL*0continuation; its emalloc'd name is neither stored nor freed.Fix
In
php_mimeheader_alloc_from_tok, when the active RFC2231 name matches the new plain parameter, free the duplicate name. The guard isname != name_bufso it only frees a separate allocation, never the livename_bufthat the first encoded parameter aliases (which would be a use-after-free on the next iteration).