Improve Docker build process, remove --disable-segfault-error#5552
Merged
Conversation
Member
|
I'm not familiar with Docker, so I can't review it. |
Member
Author
No worries. Much appreciated to let me know. |
Contributor
|
The CMD change is fine, but I don't like the Makefile change. make lets you add file names as dependencies to tasks, and when the file changes, it will re-run the task. Adding the Dockerfile as dependency should fix that without manually comparing hashes. |
Member
Author
|
Thank you for checking @cweiske. I didn't know it was that simple. But it seems to do the trick. |
Contributor
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php/doc-base#285 removed
--disable-segfault-error. Dockerfile was still passing this argument resulting in a warning. Thus we should remove it as well.Also altered
Makefileto write a file hash to .docker/built instead. If we don't this warning will still pop unless we manually remove that file.