poster alternate text#15
Open
Shaxadhere wants to merge 1 commit into
Open
Conversation
Author
|
@huynhdev24 Can you also merge this PR. |
Author
|
why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently used this package in one of my react project and It's really helpful, one thing that kept bothering me was it would show "Tuby Poster" when poster image is not loaded and I decided to add it in your package, I've added a way to add poster alt text from props, this way I can just add video's title in alternate text. I've made small changes, please approve and merge them when you get time.