Skip to content

Era accurate guild shops#98

Draft
montijin wants to merge 10 commits into
phoenixffxi:betafrom
montijin:era-guild-shops
Draft

Era accurate guild shops#98
montijin wants to merge 10 commits into
phoenixffxi:betafrom
montijin:era-guild-shops

Conversation

@montijin

@montijin montijin commented Jul 8, 2026

Copy link
Copy Markdown

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds era accurate guild shops by adding, removing, changing restock rates and price curves to various items to match documented era numbers.

Steps to test these changes

Check the prices and items available at guild vendors.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

✨ Hello and thanks for the PR! ✨

🤖: This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template.

Comment thread modules/abyssea/lua/era_guild_shops.lua Outdated
Comment thread modules/abyssea/lua/era_guild_shops.lua Outdated
patchStock('Ndego', xi.item.BRONZE_SHEET, { initial = 12 }) -- Bronze Sheet
patchStock('Ndego', xi.item.IRON_SHEET, { initial = 12 }) -- Iron Sheet
patchStock('Ndego', xi.item.MANDREL, { initial = 120 }) -- Mandrel
patchStock('Ndego', xi.item.WORKSHOP_ANVIL, { initial = 120 }) -- Workshop Anvil

@Skold177 Skold177 Jul 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier on the eyes to clean these up.
Also you can probably remove the item comments on the end as well since all the items are keyed by the ENUM entry

patchStock('Ndego', xi.item.CHUNK_OF_COPPER_ORE, { initial = 120 }) 
patchStock('Ndego', xi.item.CHUNK_OF_TIN_ORE,    { initial = 120 }) 
patchStock('Ndego', xi.item.CHUNK_OF_IRON_ORE,   { initial = 120 }) 
patchStock('Ndego', xi.item.BRONZE_INGOT,        { initial =  12 }) 
patchStock('Ndego', xi.item.IRON_INGOT,          { initial =  12 }) 
patchStock('Ndego', xi.item.BRONZE_SHEET,        { initial =  12 }) 
patchStock('Ndego', xi.item.IRON_SHEET,          { initial =  12 }) 
patchStock('Ndego', xi.item.MANDREL,             { initial = 120 }) 
patchStock('Ndego', xi.item.WORKSHOP_ANVIL,      { initial = 120 }) 

Comment on lines +1 to +4
-----------------------------------
-- Era Guild Shared Stocks
-- A module to link guild shops to share stocks
-----------------------------------

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also move these into phoenix/lua, with the guild point modules.

Comment thread modules/abyssea/lua/era_guild_shops.lua Outdated
removeStock('Khel_Pahlhama', xi.item.PENDANT_COMPASS) -- Pendant Compass
removeStock('Paunelie', xi.item.PENDANT_COMPASS) -- Pendant Compass

return { name = moduleName }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that just a fantastic job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants