Skip to content

[lua] Fixes Dynamis hourglass trade being locked#111

Merged
CriticalXI merged 1 commit into
phoenixffxi:betafrom
Frankie-hz:dynaglass
Jul 11, 2026
Merged

[lua] Fixes Dynamis hourglass trade being locked#111
CriticalXI merged 1 commit into
phoenixffxi:betafrom
Frankie-hz:dynaglass

Conversation

@Frankie-hz

Copy link
Copy Markdown

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Changes the item check for timeless hourglass so the item does not get locked on a failed trade attempt.

Steps to test these changes

First Test
!additem timeless_hourglass
Trade the hourglass to the markings -> FAIL THE TRADE (hit cancel)
Trade it again see that it works.

Second Test
!additem timeless_hourglass
Trade it successfully
Enter Dyna
Leave Dyna
!additem timeless_hourglass
Trade the hourglass again as many times as you want
Get the same "occupying dynamis" message

@CriticalXI CriticalXI enabled auto-merge (squash) July 11, 2026 00:25
@CriticalXI CriticalXI merged commit 31d0583 into phoenixffxi:beta Jul 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants