fix(lint): resolve all 19 ESLint errors across 9 files - #588
Merged
Conversation
Fixes: - react-hooks/exhaustive-deps: wrap derived values in useMemo - react-hooks/set-state-in-effect: derive during render or suppress with justification for legitimate sync patterns - @next/next/no-img-element: suppress for office-render thumbnails - prefer-const / no-useless-assignment: clean up mutable bindings - preserve-caught-error: attach cause when rethrowing - no-useless-escape: remove unnecessary backslashes in regex - no-undef: use globalThis.URL for Node.js ESM globals - @typescript-eslint/no-unused-vars: prefix unused declarations Co-authored-by: Crush (GLM 5.2) <crush@local>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughPresentation selection and speaker-notes state handling are updated alongside error-cause preservation, tooling adjustments, MCP transport initialization changes, and a refactor of hue normalization logic. ChangesMaintenance updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run lintwas reporting 19 errors across 9 files. This PR resolves all of them.Changes by category
react-hooks/exhaustive-depsuseMemoreact-hooks/set-state-in-effect@next/next/no-img-elementpreserve-caught-error{ cause }when rethrowingno-useless-assignmentlet+ reassign toconstexpressionno-useless-escape\[inside character classes@typescript-eslint/no-unused-vars_prefer-constno-undefglobalThis.URLfor Node.js ESMTest plan
npm run lint→ 0 errorsnpx tsc --noEmit→ passesSummary by CodeRabbit