Fix buffer overflows, resource leaks, and unchecked I/O returns#52
Open
forrie wants to merge 1 commit into
Open
Fix buffer overflows, resource leaks, and unchecked I/O returns#52forrie wants to merge 1 commit into
forrie wants to merge 1 commit into
Conversation
- Replace strcpy/sprintf with snprintf in fbconfig.c to prevent buffer overflows when HOME path is long - Fix file handle and malloc leaks in state.c ROM loading by restructuring error paths with goto cleanup - Add NULL check for ROM buffer malloc in state.c - Validate fread/fwrite return values in diskraw.c, diskimd.c, wd2010.c, and wd279x.c to detect short reads/writes - Log PTY write failures in i8274.c instead of silently discarding - Rename lightbar.c to lightbar_data.h to reflect its role as embedded GIMP pixel data (not a compiled translation unit) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strcpy/sprintfwithsnprintfinfbconfig.cto prevent buffer overflows when$HOMEpath is longstate.cROM loading by restructuring error paths with goto cleanupstate.cfread/fwritereturn values indiskraw.c,diskimd.c,wd2010.c, andwd279x.cto detect and report short reads/writesi8274.cinstead of silently discarding the return valuelightbar.ctolightbar_data.hto reflect its role as embedded GIMP pixel data (not a compiled translation unit)Test plan
make clean && makebuilds cleanly with zero new warnings (only pre-existing unused-function warnings ini8274.con non-Linux)🤖 Generated with Claude Code