lift the network lines off the ground#90
Open
hawc2 wants to merge 1 commit into
Open
Conversation
eugenethreat
temporarily deployed
to
line-z-elevation - pcwnetworkmap-previews PR #90
Render
Destroyed
Member
|
@hawc2 thanks for doing research into this, big improvement over what we used to have! I can't look at this too in-depth right now but will get to it as soon as I can. Noting the z-axis value will need to be adjusted based off each building's height, particularly the high sites > routers 
|
Member
|
and FYI the preview errors are related to some environment related issues on Render's side, but the next deploy preview should have the right build commands off the get-go instead of me having to set them per preview. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@eugenethreat @fmvaldezg I took a shot at addressing #45 using
line-z-offset+line-elevation-reference, with vertical options for all 4 layers.This requires projection, setting up 'mercator' in map-init, which is a site-wide switch (Mapbox silently ignores line-z-offset under the default globe projection).
There are various default settings and secondary effects this may have that'll require further edits and polishing...