Replace empty directory env variable by default value#19
Open
Iceows wants to merge 1 commit into
Open
Conversation
Replace empty directory env variable by default value. Root cause : Huawei hi6250 define in init.hi6250.rc ANDROID_STORAGE to "", so check empty string and replace with default path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the cause of the problem. It wasn't the volume name that was empty, just the environment variable that set the start of the external storage volume's default path : env name : ANDROID_STORAGE.
It is set to "" in an init rc file ( init.hi6250.rc) at the vendor level and the source code tests only null value and not also empty value
Issue describe the bug :
phhusson/treble_experimentations#2386
No default sound and list of system sound (ringtones, alarms, notify) is empty #2386
Replace empty directory env variable by default value.
Root cause :
Huawei hi6250 define in init.hi6250.rc ANDROID_STORAGE to "", so check empty string and replace with default path.