Skip to content

New user documentation#154

Draft
glelouet wants to merge 4 commits into
phax:masterfrom
glelouet:modif_readme_tests
Draft

New user documentation#154
glelouet wants to merge 4 commits into
phax:masterfrom
glelouet:modif_readme_tests

Conversation

@glelouet
Copy link
Copy Markdown
Contributor

@glelouet glelouet commented May 29, 2026

  • README.md
  • docs/contributing.md
  • docs/extending.md
  • docs/overview.md
  • docs/starting.md

initial :

@phax please make a pass to check if that is clear. The goal is to help other people, not make them more confused :D

@phax
Copy link
Copy Markdown
Owner

phax commented May 29, 2026

Looks fine to me. Do you want to add something on top of it?
Shall we add a statement on different Java versions, to use Maven profiles (I know I need to check the switch expression pr...)

@phax phax self-assigned this May 29, 2026
@glelouet glelouet marked this pull request as draft May 29, 2026 19:36
@glelouet
Copy link
Copy Markdown
Contributor Author

glelouet commented May 29, 2026

I think you're right, each feature should be documented. That would go in a dedicated doc/ folder though. Or docs / ? Or keep them at root / with .md to know they are doc ? I rather have them in dedicated folder, even though it makes links more awkard (starting with ../ )
Anyhow I rather have the root README.md cleaner with only simplest, most important things, but I agree that a nice doc goes a long way in helping people use a library more useful.

Now I don't think we should doc each feature about code, as those are better kept up-to-date with tests.
However I think a few features could be made tests for in the new jcodemodel-tests module since that contains both the generating code, and the generated resulting classes.

I made it a draft and will think about it once you give your opinion about the location, and the creation of additional test/example classes. Should I make an issue ? This way we can list what we want.

@glelouet glelouet force-pushed the modif_readme_tests branch from e2baebc to 8b13b8c Compare May 31, 2026 14:17
@glelouet
Copy link
Copy Markdown
Contributor Author

No answer, I put the doc in /documentation/ dir, with one contribution.md

@phax
Copy link
Copy Markdown
Owner

phax commented May 31, 2026

Super - sounds good :-) Thanks for your efforts

@phax
Copy link
Copy Markdown
Owner

phax commented May 31, 2026

Usually, I call the order docs but that really doesn't matter. So fine for me

@glelouet
Copy link
Copy Markdown
Contributor Author

glelouet commented May 31, 2026

No, we use docs. No point in being confused, I personally don't care. And I also usually go with docs/ .

@glelouet
Copy link
Copy Markdown
Contributor Author

glelouet commented May 31, 2026

@phax can you check the two md files ? starting is for people willing to use jcm, contributing is for people willing to help .

Note that I also changed the root readme.

@phax
Copy link
Copy Markdown
Owner

phax commented May 31, 2026

Sounds all fine for me - ready to merge?

@glelouet
Copy link
Copy Markdown
Contributor Author

glelouet commented May 31, 2026

I need to add part on using the plugins (in using.md) .

edit : plus a part on the general architecture (overview.md) alongside the scripts present, and a part on how to produce new generators (extending.md).

@glelouet glelouet changed the title Readme : adding testing explanations New user documentation May 31, 2026
@glelouet
Copy link
Copy Markdown
Contributor Author

@phax I added tasks at the top. Can you check that you can tick the README ; then check if README changes are correct, untick it if not ?

I made a second pass on starting. If you think it's good, tick it please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants