Skip to content

test(plan): cy-02r — drop cy-863 miri gate (cy-208 cursor::free fix landed via fork)#45

Merged
phall1 merged 1 commit into
mainfrom
feat/cy-02r
May 11, 2026
Merged

test(plan): cy-02r — drop cy-863 miri gate (cy-208 cursor::free fix landed via fork)#45
phall1 merged 1 commit into
mainfrom
feat/cy-02r

Conversation

@phall1
Copy link
Copy Markdown
Owner

@phall1 phall1 commented May 11, 2026

`cargo update` bumped rowan to `phall1/rowan:fix/sb-node-cache-rehash@9e7abd11` which carries cy-208's cursor::free + to_next_sibling* fixes. the cy-863 plan test (`lower_statement_no_panic_on_unresolved_inside_patternpredicate_text`) now passes under miri without the `#[cfg(not(miri))]` gate.

removed:

  • the gate
  • the explanatory comment paragraph above it (pointed at cy-208 which is now closed)

verified:

  • `cargo +nightly miri test -p cyrs-plan -- lower_statement_no_panic_on_unresolved_inside_patternpredicate_text` passes
  • `cargo clippy --workspace --all-targets --all-features -- -D warnings` clean
  • `cargo test --workspace` clean

refs: cy-02r, cy-863, cy-208, cy-yrz, rust-analyzer/rowan#211, rust-analyzer/rowan#212

…anded via fork)

cargo update bumped rowan to phall1/rowan:fix/sb-node-cache-rehash@9e7abd11
which carries the cursor::free + to_next_sibling* fixes from cy-208.
The cy-863 plan test now passes under miri without the gate.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
phall1 pushed a commit that referenced this pull request May 11, 2026
…e prep merged

cy-yrz (PR #43): rowan 0.15→0.16, [patch.crates-io] to phall1/rowan,
dropped cy-eu2 fmt cfg(not(miri)) gates. SB rehash bug confirmed dead
in CI logs.

cy-y1k (PR #44): workspace 0.1.0, manifest fields, CHANGELOG.md,
docs/release-playbook.md enumerates 19 publishable crates in dep
order. cargo publish + tag + binary builds remain manual user steps.

cy-02r is open (PR #45) — drops the cy-863 miri gate now that
cy-208's cursor::free fix is on the fork branch.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@phall1 phall1 merged commit 8c4a73c into main May 11, 2026
73 of 84 checks passed
@phall1 phall1 deleted the feat/cy-02r branch May 11, 2026 01:36
phall1 pushed a commit that referenced this pull request May 11, 2026
- close cy-02r (cy-863 miri gate dropped, PR #45 merged)
- copy workspace LICENSE-APACHE + LICENSE-MIT into editors/vscode/ so
  vsce package picks them up
- drop the placeholder icon.png reference from editors/vscode/package.json
  (vsce was failing to package because the file didn't exist; user can
  add a real icon and re-add the field before marketplace publish)

cyrs-vscode-0.0.1.vsix now builds clean. Marketplace upload is the
user's manual step.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant