test: fix eval-smoke + yolo tests on Windows#16
Merged
Conversation
- _write_manifest now TOML-escapes backslashes, so tmp_path manifests with C:\... paths parse (\U was an invalid TOML unicode escape, so the 8 smoke tests failed only on Windows). - yolo default-checkpoint assertion uses Path.as_posix() instead of a hard-coded forward-slash str().endswith(). No-op on POSIX CI; unblocks the local Windows run. The 17 video tests also needed cv2, which the dev extra already declares (pip install -e .[dev]). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test-only fixes so the suite passes on Windows (no-ops on Linux CI):
_write_manifest(eval-smoke) now TOML-escapes backslashes. tmp_path manifests embedC:\Users\..., and\Uis an invalid TOML unicode escape, so all 8 smoke tests raised an Invalid-hex-value error only on Windows.Path.as_posix()instead of a hard-coded forward-slash str-endswith check.Context: the other 17 local failures were a missing
cv2module -- the dev extra already declaresopencv-python-headless, so installing the dev extra covers them; no code change needed.Local result: 378 passed, 4 skipped (was 26 failed).
Generated with Claude Code