Skip to content

Update Swedish (sv) translation#9764

Closed
yeager wants to merge 4 commits intopgadmin-org:masterfrom
yeager:update-swedish-translation
Closed

Update Swedish (sv) translation#9764
yeager wants to merge 4 commits intopgadmin-org:masterfrom
yeager:update-swedish-translation

Conversation

@yeager
Copy link
Copy Markdown
Contributor

@yeager yeager commented Mar 18, 2026

Swedish Translation Update

Changes

  • Fix terminology: 'bord' → 'tabell' throughout (15+ strings)
  • Fix placeholder errors in format strings
  • Remove fuzzy flag from header
  • Standardize database terminology (Vy, Tabellrymd, Utlösare/Trigger)
  • Professional DBA terminology review

Stats

  • 3,625 translated strings
  • 39 insertions, 40 deletions
  • Quality: 9+/10 (professional review)

Context

Swedish translation was reviewed and corrected by a professional translator with PostgreSQL DBA experience. All database-specific terminology follows established Swedish standards.

Summary by CodeRabbit

  • Chores
    • Improved Swedish translations across the app: corrected terminology (e.g., table/tablespace wording), refined UI labels, prompts, error and warning messages, and help text for greater clarity and consistency.
    • Fixed punctuation/spacing and updated structured instructional text to use correct field names for clearer Swedish guidance.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 18, 2026

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (14)
  • web/pgadmin/translations/cs/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/de/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/es/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/fr/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/id/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/it/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/ja/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/pl/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/pt_BR/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/ru/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/sv/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/sv/LC_MESSAGES/messages.po
  • web/pgadmin/translations/zh_Hans_CN/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/zh_Hant_TW/LC_MESSAGES/messages.mo
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4f4159e1-2c1e-4c50-87fd-c4b7ae5eadd7

📥 Commits

Reviewing files that changed from the base of the PR and between c071715 and 68f174e.

📒 Files selected for processing (14)
  • web/pgadmin/translations/cs/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/de/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/es/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/fr/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/id/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/it/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/ja/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/pl/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/pt_BR/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/ru/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/sv/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/sv/LC_MESSAGES/messages.po
  • web/pgadmin/translations/zh_Hans_CN/LC_MESSAGES/messages.mo
  • web/pgadmin/translations/zh_Hant_TW/LC_MESSAGES/messages.mo

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Updated the Swedish pgAdmin translation catalog (messages.po): metadata header adjusted and numerous msgstr entries revised (terminology, punctuation, JSON field names, and some source reference path changes) without changing application code or behavior.

Changes

Cohort / File(s) Summary
Swedish translation file
web/pgadmin/translations/sv/LC_MESSAGES/messages.po
Removed fuzzy header marker and updated PO-Revision-Date; revised many Swedish translations (e.g., replacing “bord”→“tabell”, tablespace terminology), corrected JSON-field labels (rollrole, ärvainherit, leverantör/etikettprovider/label), adjusted punctuation/spacing, and updated one source reference path prefix. No functional/code changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Update Swedish (sv) translation' accurately and concisely summarizes the main change—a translation update for the Swedish locale in pgAdmin. It is clear and specific enough for teammates scanning history.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@web/pgadmin/translations/sv/LC_MESSAGES/messages.po`:
- Line 11: Find the translation entry whose msgid/msgstr pair has mismatched
positional placeholders (the one reported by the placeholder-balance check) and
edit the msgstr so its placeholders exactly match the msgid in both count and
position (e.g., use the same %s, %d or numbered forms like %1$s/%2$d in the same
order). Make sure not to remove or reorder placeholders; if the source uses
numbered placeholders, mirror those numbers in the Swedish msgstr, and then
re-run the translation checks (msgfmt or the project’s pipeline) to confirm the
placeholder-balance error is resolved.
- Line 5006: Summary: Fix the typo in the translation reference where "pgladmin"
should be "pgadmin". Edit the reference line that currently begins with "#:
pgladmin/browser/server_groups/servers/databases/schemas/views/static/js/view.js:55"
in messages.po and change "pgladmin" to "pgadmin" so the path reads "#:
pgadmin/...", and scan the file for any other occurrences of "pgladmin" to
correct them similarly.
- Line 7413: Replace the misspelled Swedish translation string msgstr "Nästad
tabell" with the correct wording "Nästlad tabell" for the "Nested Table" entry
(update the msgstr value for the translation keyed by the corresponding msgid
for "Nested Table").

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7097d0b7-1068-498d-99aa-f390fb86b8c4

📥 Commits

Reviewing files that changed from the base of the PR and between 2576548 and 035d659.

📒 Files selected for processing (1)
  • web/pgadmin/translations/sv/LC_MESSAGES/messages.po

"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
"POT-Creation-Date: 2026-02-26 18:55+0530\n"
"PO-Revision-Date: 2025-06-09 15:34+0200\n"
"PO-Revision-Date: 2026-03-18 15:22+0100\n"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Fix the failing placeholder-balance check before merge.

The translation pipeline is currently failing with positional format placeholders are unbalanced (reported at Line 825 in this file). Please fix the affected msgstr so its positional placeholders exactly match the corresponding msgid.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@web/pgadmin/translations/sv/LC_MESSAGES/messages.po` at line 11, Find the
translation entry whose msgid/msgstr pair has mismatched positional placeholders
(the one reported by the placeholder-balance check) and edit the msgstr so its
placeholders exactly match the msgid in both count and position (e.g., use the
same %s, %d or numbered forms like %1$s/%2$d in the same order). Make sure not
to remove or reorder placeholders; if the source uses numbered placeholders,
mirror those numbers in the Swedish msgstr, and then re-run the translation
checks (msgfmt or the project’s pipeline) to confirm the placeholder-balance
error is resolved.

Comment thread web/pgadmin/translations/sv/LC_MESSAGES/messages.po Outdated
Comment thread web/pgadmin/translations/sv/LC_MESSAGES/messages.po Outdated
@akshay-joshi
Copy link
Copy Markdown
Contributor

@yeager

Please fix coderabittai review comments and translation builds are failing

yeager pushed a commit to yeager/pgadmin4 that referenced this pull request Mar 26, 2026
- Keep JSON field names (role, admin, inherit, provider, label) untranslated
- Fixes format string mismatch flagged by CodeRabbitAI
- Resolves placeholder validation errors in PR pgadmin-org#9764
@khushboovashi
Copy link
Copy Markdown
Contributor

Hi @yeager, please rebase your branch and also resolve the Coderabbitai review comments.

yeager pushed a commit to yeager/pgadmin4 that referenced this pull request Mar 27, 2026
- Keep JSON field names (role, admin, inherit, provider, label) untranslated
- Fixes format string mismatch flagged by CodeRabbitAI
- Resolves placeholder validation errors in PR pgadmin-org#9764
@yeager yeager force-pushed the update-swedish-translation branch from c071715 to 6e5be69 Compare March 27, 2026 06:09
Daniel Nylander added 4 commits March 28, 2026 08:28
- Fix terminology: 'bord' → 'tabell' throughout
- Fix placeholder errors in format strings
- Remove fuzzy flag from header
- Standardize database terminology (Vy, Tabellrymd, Utlösare)
- 3625 translated strings, professional DBA review
- Keep JSON field names (role, admin, inherit, provider, label) untranslated
- Fixes format string mismatch flagged by CodeRabbitAI
- Resolves placeholder validation errors in PR pgadmin-org#9764
Add comma before 'och' after %SCHEMA% to prevent babel from
misinterpreting '% o' as a positional format placeholder.
- Restore missing colons in security label JSON templates (label: <label>)
- Restore untranslatable JSON keys in config variable templates
  (database, name, value should remain as English JSON keys)
@yeager yeager force-pushed the update-swedish-translation branch from 87a2ea7 to 68f174e Compare March 28, 2026 07:29
@yeager
Copy link
Copy Markdown
Contributor Author

yeager commented Mar 28, 2026

Rebased on latest master and fixed the placeholder issue (added comma after %SCHEMA%/%USERNAME% etc. to prevent babel from interpreting % o as python-format octal).

  • pybabel compile passes ✅ (3612/3674 = 98%)
  • msgfmt --check passes ✅
  • All CI checks were green on the previous push

Ready for review.

asheshv pushed a commit that referenced this pull request May 2, 2026
- Database terminology corrections (bord → tabell, Visa → Vy, etc.)
- Standardize Tabellrymd, Sammansatt utlösare
- Fix punctuation in placeholder lists (Oxford-comma alignment)
- Drop incorrect fuzzy flag from .po header

Note: msgid "on" (from ai_tools.js) is missing here because the PR's
.po was regenerated against a slightly older source tree; it will be
re-added on the next `make messages` run.
@asheshv
Copy link
Copy Markdown
Contributor

asheshv commented May 2, 2026

Hi @yeager — thank you for the careful Swedish update, especially the bord→tabell and Visa→Vy corrections. The terminology cleanup is solid.

I've landed the Swedish .po as 119a993 with you as the commit author, so your attribution is preserved.

I had to drop the cross-language .mo binaries from this PR — they were compiled against an older base and would have reverted recently merged work in other languages (e.g., the Russian update in #9839 lost ~315 strings, Czech ~48). The sv/messages.mo will be rebuilt automatically from the new .po on the next make messages run.

One small note: the msgid "on" from llm/static/js/ai_tools.js is missing in the applied .po because your update was generated against a slightly older source tree — pybabel update will re-add it (with empty msgstr) on the next catalog rebuild, so no action needed.

Closing this PR in favor of the direct commit. Thanks again!

@asheshv asheshv closed this May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants