fix: compare territory FIPS codes instead of abbreviations in dep_get_index#73
Merged
Merged
Conversation
…_index validate_state() converts abbreviations to FIPS before the territory check runs. The check now compares against FIPS codes (60, 66, 69, 72, 78) so it catches both abbreviation and raw FIPS input. Un-skips and expands the territory validation test to cover all five territories by both input formats. Closes #72 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the territory validation bug in
dep_get_index()where the guard clause compared FIPS codes (output ofvalidate_state()) against abbreviation strings, causing the check to never match.Implementation
"AS", "GU", "MP", "PR", "VI") to FIPS codes ("60", "66", "69", "72", "78")dep_territory_fips()helper convention indep_get_data.RTesting
test_dep_get_index.RpassCloses
Closes #72
Notes
Single-line logic fix; no API or behavioral changes beyond correcting the broken validation path.