Skip to content

fix: add Chrome ID guard to build script + bump to v1.0.17 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pexatar merged 1 commit into from
May 14, 2026
Merged

fix: add Chrome ID guard to build script + bump to v1.0.17 #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Installer/PassKey.iss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
[Setup]
AppId={{A7F3C2D1-8E4B-4F9A-B6D5-3C1E7A2F0D84}
AppName=PassKey
AppVersion=1.0.16
AppVerName=PassKey 1.0.16
AppVersion=1.0.17
AppVerName=PassKey 1.0.17
AppPublisher=Giuseppe Imperato
AppPublisherURL=https://github.com/pexatar/PassKey
AppSupportURL=https://github.com/pexatar/PassKey/issues
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ PassKey stores your passwords, credit cards, identities, and secure notes in a l

| Version | Platform | Type |
|---------|----------|------|
| [v1.0.16](https://github.com/pexatar/PassKey/releases/tag/v1.0.16) | Windows x64 | Installer EXE |
| [v1.0.16](https://github.com/pexatar/PassKey/releases/tag/v1.0.16) | Windows x64 | Portable ZIP |
| [v1.0.17](https://github.com/pexatar/PassKey/releases/tag/v1.0.17) | Windows x64 | Installer EXE |
| [v1.0.17](https://github.com/pexatar/PassKey/releases/tag/v1.0.17) | Windows x64 | Portable ZIP |

> **Requirements:** Windows 10 version 1809 (build 17763) or later, x64 processor.
> No .NET runtime required — PassKey is fully self-contained.
Expand Down
13 changes: 13 additions & 0 deletions scripts/build-installer.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,19 @@ param(
$ErrorActionPreference = "Stop"
$RepoRoot = Split-Path -Parent $PSScriptRoot

# Guard: block release builds that still contain the development Chrome Extension ID.
# The dev ID (jmdd...) must never appear in src/ or scripts/ — only the Web Store ID (jadf...) is valid.
$devChromeId = "jmddfinmjgpgmfkiblhnjccagheadpop"
$hits = Get-ChildItem -Recurse -File -Path "$RepoRoot\src","$RepoRoot\scripts" |
Select-String -Pattern $devChromeId -ErrorAction SilentlyContinue
if ($hits) {
$locations = $hits | ForEach-Object { " $($_.Filename):$($_.LineNumber)" }
Write-Error ("BUILD BLOCKED: development Chrome Extension ID found in source.`n" +
"Replace '$devChromeId' with the Web Store ID in:`n" +
($locations -join "`n"))
exit 1
}

Write-Host "=== PassKey Build Script ===" -ForegroundColor Cyan
Write-Host "Configuration: $Configuration"
Write-Host "Output: $OutputDir"
Expand Down
6 changes: 3 additions & 3 deletions src/PassKey.Desktop/PassKey.Desktop.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<WindowsPackageType>None</WindowsPackageType>
<PublishAot>false</PublishAot>
<RootNamespace>PassKey.Desktop</RootNamespace>
<Version>1.0.16</Version>
<AssemblyVersion>1.0.16.0</AssemblyVersion>
<FileVersion>1.0.16.0</FileVersion>
<Version>1.0.17</Version>
<AssemblyVersion>1.0.17.0</AssemblyVersion>
<FileVersion>1.0.17.0</FileVersion>
<ApplicationManifest>app.manifest</ApplicationManifest>
<ApplicationIcon>Assets\PassKey.ico</ApplicationIcon>
<DefineConstants>DISABLE_XAML_GENERATED_MAIN</DefineConstants>
Expand Down
Loading