Polish network auth and topic detail state#84
Merged
Conversation
fannnzhang
marked this pull request as ready for review
June 8, 2026 07:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch is based on the latest
mainafter the existing PRs were merged.third_party/openwireto upstream65ca019, including the latest auth, cache, redirect, HTTP/2, and websocket fixesRenderDocumentpath only, with quote chrome/avatar filtering kept out of platform parsingValidation
Full branch validation before the latest focused cache/count commits:
./scripts/check_clean_submodules.shcargo fmt --all --checkcargo clippy -p fire-models -p fire-core -p fire-uniffi --all-targets --no-deps -- -D warningscargo clippy -p fire-models -p fire-core -p fire-uniffi --all-targets --no-deps --release -- -D warningscargo test -p fire-models -p fire-store -p fire-core -p fire-uniffi --all-targetscargo test -p openwire --features websocket --lib policy::cargo test -p fire-core --test network -- --nocapturecd native/android-app && ./gradlew clean testDebugUnitTest assembleDebugxcodegen generate --spec native/ios-app/project.ymlgit diff --exit-code -- native/ios-app/Fire.xcodeprojcd native/ios-app && FIRE_SKIP_UNIFFI_BINDGEN=1 xcodebuild -project Fire.xcodeproj -scheme Fire -destination 'platform=iOS Simulator,name=Fire-Local-Unit' -derivedDataPath /tmp/fire-ios-final testFocused checks after the latest cache/count commits:
git diff --checkcd native/android-app && export JAVA_HOME=$(/usr/libexec/java_home -v 17) ANDROID_HOME=/Users/zhangfan/Library/Android/sdk ANDROID_SDK_ROOT=/Users/zhangfan/Library/Android/sdk && ./gradlew testDebugUnitTest --tests 'com.fire.app.ui.home.HomeTopicListMessageBusRefreshControllerTest' --tests 'com.fire.app.TopicPresentationTest'cd native/ios-app && xcodebuild -project Fire.xcodeproj -scheme Fire -destination 'platform=iOS Simulator,name=Fire-Local-Unit' -derivedDataPath /tmp/fire-ios-topic-list-patch -only-testing:FireTests/FireTopicListMessageBusRefreshTests testcd native/ios-app && FIRE_SKIP_UNIFFI_BINDGEN=1 xcodebuild -project Fire.xcodeproj -scheme Fire -destination 'platform=iOS Simulator,name=Fire-Local-Unit' -derivedDataPath /tmp/fire-ios-topic-list-patch -only-testing:FireTests/FireTopicListMessageBusRefreshTests testFocused Boost checks after
d39ae07:cargo fmt --all --checkgit diff --checkcargo test -p fire-core --lib topic_post_boosts_parse_display_text_and_permissionscargo check -p fire-uniffi-topicsxcodegen generate --spec native/ios-app/project.ymlgit diff --exit-code -- native/ios-app/Fire.xcodeprojFIRE_SKIP_UNIFFI_BINDGEN=1 xcodebuild test -project native/ios-app/Fire.xcodeproj -scheme Fire -destination 'id=B23CBA19-C01B-4F60-8873-0B6AA1BC6907' -derivedDataPath /tmp/FireDerivedBoost -only-testing:FireTests/FirePostCellLayoutCalculatorTests -only-testing:FireTests/FirePostLayoutManagerTestscd native/android-app && export JAVA_HOME=$(/usr/libexec/java_home -v 17) ANDROID_HOME=/Users/zhangfan/Library/Android/sdk ANDROID_SDK_ROOT=/Users/zhangfan/Library/Android/sdk && ./gradlew testDebugUnitTest --tests com.fire.app.ui.topicdetail.TopicDetailPostRowsTestFocused Boost barrage checks after
b90a675:cargo fmt --all --checkgit diff --checkxcodegen generate --spec native/ios-app/project.ymlgit diff --exit-code -- native/ios-app/Fire.xcodeprojFIRE_SKIP_UNIFFI_BINDGEN=1 xcodebuild test -project native/ios-app/Fire.xcodeproj -scheme Fire -destination 'id=B23CBA19-C01B-4F60-8873-0B6AA1BC6907' -derivedDataPath /tmp/FireDerivedBoostBarrage -only-testing:FireTests/FirePostCellLayoutCalculatorTests -only-testing:FireTests/FirePostLayoutManagerTestscd native/android-app && export JAVA_HOME=$(/usr/libexec/java_home -v 17) ANDROID_HOME=/Users/zhangfan/Library/Android/sdk ANDROID_SDK_ROOT=/Users/zhangfan/Library/Android/sdk && ./gradlew testDebugUnitTest --tests com.fire.app.ui.topicdetail.TopicDetailPostRowsTestFocused Boost emoji/manual scroller follow-up after
0f94993:kept the Boost barrage path in the in-house UIKit/Android View implementation after checking third-party barrage options; no SwiftUI or third-party renderer was added
restored iOS original-post barrage resume by deferring the scroll-idle check until UIKit clears tracking/deceleration state
added Rust/UniFFI Boost
renderDocumentoutput and normalized emoji image fallback text for native emoji-capable chipschanged reply/comment Boost presentation to fixed-height two-row manual horizontal chips instead of automatic ticker scrolling
cargo fmt --all --checkcargo test -p fire-rich-text --libcargo test -p fire-core --libcargo test -p fire-uniffi-topics --libcargo test -p fire-uniffi --libcd native/ios-app && ./scripts/sync_uniffi_bindings.shxcodegen generate --spec native/ios-app/project.ymlxcodebuild test -project native/ios-app/Fire.xcodeproj -scheme Fire -destination 'platform=iOS Simulator,id=D6D8439F-582C-4C3B-A68E-696F9ADBBA00' -only-testing:FireTests/FirePostCellLayoutCalculatorTestsxcodebuild test -project native/ios-app/Fire.xcodeproj -scheme Fire -destination 'platform=iOS Simulator,id=D6D8439F-582C-4C3B-A68E-696F9ADBBA00' -only-testing:FireTests/FirePostCellLayoutCalculatorTests/testFixedBoostManualScrollerHeightIsCompactcd native/android-app && JAVA_HOME=$(/usr/libexec/java_home -v 17) ANDROID_HOME=/Users/zhangfan/Library/Android/sdk ANDROID_SDK_ROOT=/Users/zhangfan/Library/Android/sdk ./gradlew testDebugUnitTest assembleDebuggit diff --checkFocused iOS CI fix after
64c6618:fixed
FirePostCellLayoutCalculatorTests.testBodyBarrageBatchSignatureUsesVisibleNormalizedBoostBodyby keeping original-post Boost barrage batch identity tied to visible normalized Boost body text instead of raw cooked/render contentfixed
FireTopicPresentationTests.testRenderContentEmbedsEmojiAttachmentsexpectation for Rust-normalized emoji fallback text (:smile:)docs checked: existing Boost docs already describe reply/comment Boosts as fixed-height two-row manual horizontal chips without automatic ticker scrolling, and no documentation change was needed
xcodebuild test -project native/ios-app/Fire.xcodeproj -scheme Fire -destination 'platform=iOS Simulator,id=D6D8439F-582C-4C3B-A68E-696F9ADBBA00' -only-testing:FireTests/FirePostCellLayoutCalculatorTests/testBodyBarrageBatchSignatureUsesVisibleNormalizedBoostBody -only-testing:FireTests/FireTopicPresentationTests/testRenderContentEmbedsEmojiAttachmentsxcodebuild test -project native/ios-app/Fire.xcodeproj -scheme Fire -destination 'platform=iOS Simulator,id=D6D8439F-582C-4C3B-A68E-696F9ADBBA00' -only-testing:FireTests/FirePostCellLayoutCalculatorTests -only-testing:FireTests/FireTopicPresentationTestsFIRE_SKIP_UNIFFI_BINDGEN=1 xcodebuild -project native/ios-app/Fire.xcodeproj -scheme Fire -destination 'platform=iOS Simulator,id=D6D8439F-582C-4C3B-A68E-696F9ADBBA00' -derivedDataPath /tmp/fire-ios-tests CODE_SIGNING_ALLOWED=NO testxcodegen generate --spec native/ios-app/project.ymlgit diff --exit-code -- native/ios-app/Fire.xcodeprojgit diff --check