Pr claude test/board id sanity check testing#44
Open
peterbarker wants to merge 204 commits into
Open
Conversation
peterbarker
force-pushed
the
pr-claude-test/board-id-sanity-check-testing
branch
from
8bb8014 to
0c7be3d
Compare
The Tramp 'v' reply reports both configured and actual power, but only the configured value reached AP_VideoTX, hiding VTXes that ignore the request or have a hardware power floor. Expose the actual value via set/get_actual_power_mw() (-1 = not reported) and warn once when it exceeds VTX_MAX_POWER or the request by more than 50%. update_power() also rejected any mW not in the SmartAudio power table, silently dropping valid Tramp values like 2500mW. Accept off-table values when a Tramp provider is active, stashing them in the custom power slot so later equality checks still work. A VTX that silently rejects a value drove an infinite retry loop because update() re-armed retry_count on every mismatch. Re-arm only when the configured value actually changes, and warn once when retries exhaust on the same value. Also defines get_current_actual_power() and get_current_temp(), which were declared but never implemented.
draw_vtx_power() previously displayed the configured (requested) power. Tramp VTXes with a hardware power floor report a different actual value that never reached the OSD. Prefer the self-reported actual when available, falling back to configured for providers that don't report it (e.g. SmartAudio).
Allows to manually add an offset to the simulated sonar readings. Also created sub-table for SONAR_ parameters
The tests cover the new AP_SurfaceDistance parameters.
Co-authored-by: Peter Barker <pb-gh@barker.dropbear.id.au> Co-authored-by: Peter Barker <pb-gh@barker.dropbear.id.au>
…le, don't use setup-python
peterbarker
force-pushed
the
pr-claude-test/board-id-sanity-check-testing
branch
from
0c7be3d to
7f7beb7
Compare
Also create a unlimited-cap getter for readability Also improve const-correctness Also add a few helpful comments
type_slope_get_target_airspeed_cm() initialised target_airspeed_cm and then unconditionally reassigned it in the immediately following if/else, so the initial value was never used. Declare it without the redundant initialiser. Clears one clang-scan-build "Dead initialization" finding Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
was copied rather than moved into the compass library, causing param gen to fail
The simulated Solo gimbal connected back to the vehicle on a hard-coded port 5762 (SERIAL2 at instance 0). Under a non-zero SITL instance the vehicle's SERIAL2 is at base_port+2, so the gimbal never connected and MountSolo failed waiting for GIMBAL_DEVICE_ATTITUDE_STATUS. Pass the instance-aware port (base_port()+2) to SoloGimbal. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The simulated Solo gimbal connected back to the vehicle on a hard-coded port 5762 (SERIAL2 at instance 0). Under a non-zero SITL instance the vehicle's SERIAL2 is at base_port+2, so the gimbal never connected and MountSolo failed waiting for GIMBAL_DEVICE_ATTITUDE_STATUS. Pass the instance-aware port (base_port()+2) to SoloGimbal. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
These are the same as copter, initially, except for ALT_M_NSE_DEFAULT
no longer used. The DCM init shows that this is probably better done with the equivalent of `init_done` state updated as part of the update() call rather than as a separate call by the frontend.
Tools/AP_Bootloader: reserve board id AP_HW_KARSHAKH743VTOL with ID 4002 This commit targets to reserve the board ID 4002 for AP_HW_KARSHAKH743VTOL.
…AET-405-Mini Reserve IDs: - AET-H743-AIR: 2509 - AET-U7: 2510 - AET-AT405A: 2511 - AET-405-Mini: 2512 These flight controllers support Remote ID (OpenDroneID).
…05A, AET-405-Mini These IDs (base + 10000) are for OpenDroneID (Remote ID) firmware variants: - AET-H743-AIR: 12509 (base 2509) - AET-U7: 12510 (base 2510) - AET-AT405A: 12511 (base 2511) - AET-405-Mini: 12512 (base 2512)
Co-authored-by: Randy Mackay <rmackay9@yahoo.com>
timing was too tight on the phase after takeoff - vehicle was still recovering its altitude after the takeoff
the H723/H725/H730/H733/H735 parts have FDCAN3 and the updated ChibiOS FDCANv2 driver requires STM32_IRQ_FDCAN3_PRIORITY to be defined. This fixes the build of BotBloxDroneNet
we weren't checking all the contexts we were popping to see if a reset was required. Also avoid an unnecessary reboot when we need to reset anyway
tridge
force-pushed
the
pr-claude-test/board-id-sanity-check-testing
branch
from
7f7beb7 to
4884f07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing sanity checks
Classification & Testing (check all that apply and add your own)
Description