fix(cli): lower Node engine floor to >=20.18.1#5
Conversation
The CLI's own code uses nothing newer than Node 18-era APIs (global fetch, AbortSignal.timeout, standard node: builtins). The >=22.19 floor was inherited entirely from commander@15 (>=22.12) and undici@8 (>=22.19), needlessly rejecting Node 20 (still widely deployed) and even Node 22.0-22.18. Downgrade commander to ^14 (>=20) and undici to ^7 (>=20.18.1), both current and API-compatible with our usage, and set engines to the true floor of >=20.18.1. Bump to 0.1.2. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pessini
force-pushed
the
fix/cli-node-engine-floor
branch
from
f4ed661 to
0f7e22b
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4ed661a50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "engines": { | ||
| "node": ">=14.21.3" | ||
| } | ||
| }, | ||
| "node_modules/@biomejs/cli-linux-x64": { |
There was a problem hiding this comment.
This lockfile was regenerated with only the current Linux x64 native packages left; the @biomejs/biome package above still declares darwin/win32/arm64 optionalDependencies, but their package entries were deleted. On macOS, Windows, or Linux arm64 clones that run npm ci, npm has no locked native Biome package to install, so local lint/format commands such as npx biome ci . can fail even though Ubuntu CI still passes; regenerate the lock from a clean install so all platform optional entries are preserved.
Useful? React with 👍 / 👎.
1 participant
The CLI's own code uses nothing newer than Node 18-era APIs (global fetch, AbortSignal.timeout, standard node: builtins). The >=22.19 floor was inherited entirely from commander@15 (>=22.12) and undici@8 (>=22.19), needlessly rejecting Node 20 (still widely deployed) and even Node 22.0-22.18.
Downgrade commander to ^14 (>=20) and undici to ^7 (>=20.18.1), both current and API-compatible with our usage, and set engines to the true floor of >=20.18.1. Bump to 0.1.2.