PMM-7 procfs migration to v0.15.1#220
Merged
Merged
Conversation
Bumps [github.com/prometheus/procfs](https://github.com/prometheus/procfs) from 0.14.0 to 0.19.1. - [Release notes](https://github.com/prometheus/procfs/releases) - [Commits](prometheus/procfs@v0.14.0...v0.19.1) --- updated-dependencies: - dependency-name: github.com/prometheus/procfs dependency-version: 0.19.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
ademidoff
commented
May 26, 2026
|
|
||
| package utils | ||
|
|
||
| func SafeDereference[T any](s ...*T) []T { |
Member
Author
There was a problem hiding this comment.
This is taken from upstream so we don't run into conflicts when rebasing.
ademidoff
commented
May 26, 2026
| c.pushCounter(ch, "loss_of_signal_total", host.Counters.LossOfSignalCount, host.Name) | ||
| c.pushCounter(ch, "nos_total", host.Counters.NosCount, host.Name) | ||
| c.pushCounter(ch, "fcp_packet_aborts_total", host.Counters.FCPPacketAborts, host.Name) | ||
| // Note: `procfs` guarantees these a safe dereference for these counters. |
Member
Author
There was a problem hiding this comment.
We restore a bad attempt to fix the issue in a prior commit, so it now matches the usptream.
ademidoff
commented
May 26, 2026
| level.Debug(c.logger).Log("msg", "Skipping duplicate device entry", "device", deviceIdentifier) | ||
| continue | ||
| for k := range stats.Transport { | ||
| deviceIdentifier := nfsDeviceIdentifier{m.Device, stats.Transport[k].Protocol, mountAddress} |
Member
Author
There was a problem hiding this comment.
That's the breaking change from upstream (in minor version!).
ademidoff
commented
May 26, 2026
| GOLANGCI_LINT := | ||
| GOLANGCI_LINT_OPTS ?= | ||
| GOLANGCI_LINT_VERSION ?= v1.56.2 | ||
| GOLANGCI_LINT_VERSION ?= v2.6.1 |
Member
Author
There was a problem hiding this comment.
This was missed in the migration to v2.
maxkondr
approved these changes
May 26, 2026
4nte
approved these changes
May 26, 2026
JiriCtvrtka
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot was not able to bump procfs on its own because it required a couple of changes to the code. This PR both bumps up the version and fixes the migration issues.