[Chore] Remove legacy Go Desktop Bridge (superseded by penguin-repo integration) - #161
Open
PenguinzTech wants to merge 1 commit into
Open
[Chore] Remove legacy Go Desktop Bridge (superseded by penguin-repo integration)#161PenguinzTech wants to merge 1 commit into
PenguinzTech wants to merge 1 commit into
Conversation
…tegration) The standalone Go "Desktop Bridge" (Premium/Desktop/) and its CI surface are superseded by the penguind-integrated desktop client built in the penguin repo (release/v0.2.X): penguin-desktop-core + the desktop/ Tauri shell + penguin-module-waddlebot's BridgeActionProxy, which now handles OBS/webhook bridging natively as a penguind module instead of a separate Go binary. Confirmed before deleting: - No README/doc pointed users at building or downloading the legacy bridge binary externally; the only references are internal CI/dev docs. - All 4 published GitHub releases (v0.2.0, v1.0.0, v1.2.0, v1.2.0.<epoch>) have zero attached release assets, so the binary was never distributed via GitHub Releases. - The standalone Tauri client PR (#160) that would have depended on this code was closed unmerged as part of the same cleanup. Removed: - Premium/Desktop/ (Go module, source, tests, and a stray committed build artifact `waddlebot-bridge`) - .github/workflows/desktop-bridge.yml - .github/workflows/desktop-linux.yml - .github/workflows/desktop-macos.yml - .github/workflows/desktop-release.yml - .github/workflows/desktop-windows.yml - The `desktop-bridge` job and the Go-benchmark-only `performance` job embedded in .github/workflows/ci-cd.yml (both built/benchmarked Premium/Desktop exclusively and would otherwise fail on next push), plus their `needs:` references in the deploy/notify jobs. Known follow-up (not done here): docs/WORKFLOWS.md still documents the deleted Desktop Bridge workflow; left as living-doc cleanup for a separate PR rather than a speculative rewrite of that reference doc. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the legacy standalone Go "Desktop Bridge" (
Premium/Desktop/) and its CI surface. This is Phase 5 cleanup of the desktop-client migration: the functionality now lives in thepenguinrepo as a penguind-integrated app —penguin-desktop-core+ thedesktop/Tauri shell +penguin-module-waddlebot'sBridgeActionProxy(OBS/webhook bridging), committed onrelease/v0.2.X. The standalone Tauri client PR that would have depended on this Go bridge (#160) was closed unmerged as part of the same cleanup.Confirmed before deleting (no external consumers)
*.mdforDesktop Bridge/Premium/Desktopreferences — only internal CI/architecture docs (Premium/Desktop/README.md,docs/WORKFLOWS.md,docs/guides/flask-conversion.md, a dated 2025-10-30 historical record). None instruct an end user to build or download the bridge binary.v0.2.0,v1.0.0,v1.2.0,v1.2.0.<epoch>) — zero attached assets on any of them, so the binary was never distributed via GitHub Releases.feature/desktop-tauri(source branch of closed PR [Feature] Waddlebot desktop client (Tauri) — M0/M1/M2 (stacked on #159) #160) has no other open PRs based on it.What's removed
Premium/Desktop/waddlebot-bridge, 27MB binary).github/workflows/desktop-bridge.yml.github/workflows/desktop-linux.yml.github/workflows/desktop-macos.yml.github/workflows/desktop-release.yml.github/workflows/desktop-windows.ymlAdditionally removed from
.github/workflows/ci-cd.yml(found during verification, not in the original 5-file list, but left in place would break every future push since they exclusively build/benchmarkPremium/Desktop):desktop-bridgejob (Go build/vet/test/benchmark ofPremium/Desktop, matrix across 3 OSes)performancejob (its only step benchmarksPremium/Desktop— no other purpose)needs:references indeployandnotify, and thedesktop-bridge-conditioned steps innotifyVerified:
.github/workflows/ci-cd.ymlstill parses as valid YAML after edits, and nodesktop-bridge/Premium/Desktopreferences remain anywhere under.github/workflows/.Known follow-up (not done here)
docs/WORKFLOWS.md(living CI reference doc) still documents the now-deleted Desktop Bridge workflow. Left as a separate doc-cleanup PR rather than a speculative rewrite of a 950+ line reference doc in this change.docs/guides/flask-conversion.mdis a dated point-in-time record (2025-10-30) and correctly left as-is.Note: dependabot PR #151 (
Bump the go_modules group across 4 directories) touchesPremium/Desktop/go_modulesand will likely auto-close/go stale once this merges — no action needed here.Test plan
git rm -r Premium/Desktop/+ 5 workflow files, verified viagit statusPremium/Desktop/desktop-bridgereferences post-deletion — none outside the two known docs aboveci-cd.ymlvalidated withpython3 -c "import yaml; yaml.safe_load(...)"🤖 Generated with Claude Code