Update egg-pterodactyl-vanilla-bedrock-a-r-m64.json#82
Open
Notacod3r wants to merge 1 commit into
Open
Conversation
Fix the non-functional egg install by refactoring the script to default BEDROCK_VERSION to “latest,” add jq, replace brittle HTML scraping with Mojang’s JSON API for the download URL, use a consistent ZIP filename, fail fast on directory errors, atomically back up/restore configs in /tmp/config_backup, and surface clear error messages on any failure.
Author
|
Fix for #81 |
Contributor
please update plican eggs too. else this PR will not merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the non-functional ARM64 Vanilla Bedrock egg installer by refactoring the install script to:
BEDROCK_VERSIONto “latest” if unsetjqutility and switch to Mojang’s JSON API (replacing brittle HTML scraping) for grabbing the server download URLbedrock-server-installer.zip)cd /mnt/server || exit 1)/tmp/config_backupChecklist for all submissions
Have you followed the guidelines in our [Contributing document](https://github.com/pelican-eggs/minecraft/blob/main/CONTRIBUTING.md)?
Have you checked to ensure there aren't other open [Pull Requests](../pulls) for the same update/change?
Have you tested and reviewed your changes with confidence that everything works?
Did you branch your changes and PR from that branch and not from your master branch?
You verify that the start command applied does not use a shell script
The egg was exported from the panel
New egg Submissions
Does your submission pass tests (server is connectable)?
Does your egg use a custom docker image?
Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
Have you added a unique README.md for the egg you are adding according to the alphabetical order?
You verify that the start command applied does not use a shell script
The egg was exported from the panel