changed all eggs to new installer images#100
Conversation
|
We have pelican managed java install images now. You can use either of the following. Each has a reason to be there. Some newer mc version will require java 17 to build properly.
|
…/pelican-eggs/installers:java_8; side-effekt: all install images now include the jdk
|
Egg's that need Testing:
|
|
Have you done a find for the openjdk images on all the eggs yet? I feel like this is missing many that will need to be updated. I am certain Fabric is on the list as I have tested that locally |
|
@DaNussi Can you please check for other eggs that use the old images as well please. |
|
@parkervcp can do, but it's going to take some time i am currently bussy with university 😆 |
|
@DaNussi we only have installer images for Java 8 and 17. You would use either of these
|
For some eggs i need the java-21 installer. Should i create a PR in https://github.com/pelican-eggs/yolks that adds it or is there an alternative like using ghcr.io/parkervcp/yolks:debian and manualy installing java-21 ? and isn't the image tag |
…/installers:java_8" changed "ghcr.io\/parkervcp\/yolks:java_11" to "ghcr.io\/pelican-eggs\/installers:java_17" changed "ghcr.io\/parkervcp\/yolks:java_21" to "ghcr.io\/pelican-eggs\/installers:java_21" temporarily
|
I created a PR to add the installers. pelican-eggs/yolks#337 |
|
A note. The Do we think this is good to go @QuintenQVD0 ? |
…image # Conflicts: # java/paper/egg-pterodactyl-paper.json
- ftb-server - fabric - glowstone - modrinth-generic - quilt
fixed issue in the installation script where installer.jar gets killed
|
Tested Egg's:
|
This looks fine to me |
|
Should I export all eggs from the panel? I have a script ready to go, but I don't want to overcomplicate the PR even further. I pushed the changes to an additional branch if needed i can just merge it into the current one DaNussi@e50db8c |
Looking at that seems like it didn't go that well and the indentation is wrong, just keep it like this is fine |
…installers to ghcr.io/pelican-eggs/installers
That's fine for now. You could replace them all with pelican-eggs but right now there is no real need right now. |

Description
This PR resolves #98. I have gone ahead and replaced all occurrences of openjdk:8-jdk-slim with eclipse-temurin:8. This should be a drop-in replacement. I have only tested the Curseforge Generic egg; let me know if further testing is required. 😄
Checklist for all submissions