Skip to content

upgrade joi and version up node engine#147

Merged
orangejulius merged 1 commit into
pelias:masterfrom
heons:master
May 29, 2026
Merged

upgrade joi and version up node engine#147
orangejulius merged 1 commit into
pelias:masterfrom
heons:master

Conversation

@heons

@heons heons commented May 25, 2026

Copy link
Copy Markdown
Contributor

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.


Here's the reason for this change 🚀

  • To remove deprecation warning during the package install by replacing deprecated @hapi/joi with a direct replacement of it;joi

Here's what actually got changed 👏

  • Replace @hapi/joi with a direct replacement of it;joi
  • Node engine version up to >=14 to match with the minimum version support of joi

Here's how others can test the changes 👀

It's a direct replacement. No further tests required.

Reference

[1] https://joi.dev/resources/status/
[2] https://www.npmjs.com/package/joi?v=17.13.3

@orangejulius

Copy link
Copy Markdown
Member

Hey @heons,
Thanks for this! We're looking at upgrading a bunch of old dependencies, and this one is top of the list. I was looking at it briefly myself so know this change should be valid.

LMK if there are other dependencies you were thinking of upgrading, would be great to collaborate.

@orangejulius orangejulius merged commit 7993641 into pelias:master May 29, 2026
3 checks passed
@heons

heons commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

Hi. @orangejulius Thank you for taking this in. For the next step, it would be nice to bump up the pelias-config version in the pelias-blacklist-stream :)
https://github.com/pelias/blacklist-stream/blob/master/package.json#L30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants