Skip to content

ci: run quality checks on PHP 8.5 to match the tooling floor#727

Merged
pekral merged 1 commit into
masterfrom
ci/php-85-matrix
Jun 29, 2026
Merged

ci: run quality checks on PHP 8.5 to match the tooling floor#727
pekral merged 1 commit into
masterfrom
ci/php-85-matrix

Conversation

@pekral

@pekral pekral commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Shrnutí

Opravuje repo-wide selhání CI. pekral/phpcs-rules na dev-master nově vyžaduje PHP ^8.5, takže composer install na CI matici PHP 8.4 selže:

pekral/phpcs-rules dev-master requires php ^8.5 -> your php version (8.4.22) does not satisfy that requirement

To shazuje Quality Checks job u každého PR (objeveno při pokusu o merge #726). Projekt nemá require.php a všechny tři first-party pekral/* tooling závislosti jedou na dev-master, takže floor toolchainu je teď 8.5 (lokální dev už běží na 8.5).

Co se mění

  • .github/workflows/pr.yml — PHP matrix 8.4 → 8.5 (název jobu, setup-php, cache klíče)
  • .github/workflows/composer-update.ymlsetup-php 8.4 → 8.5

Jak testovat

CI tohoto PR běží na upraveném workflow (8.5) — composer install projde a Quality Checks musí být zelené.

Odblokovává merge #726 a všech dalších PR.

pekral/phpcs-rules dev-master now requires PHP ^8.5, so 'composer install' fails
on the PHP 8.4 CI matrix ('your php version (8.4.22) does not satisfy ^8.5'),
breaking every PR's Quality Checks job. The project declares no require.php and
all three first-party pekral/* tooling deps track dev-master, so the toolchain
floor is now 8.5 (local dev already runs 8.5). Bump both workflows' PHP matrix
from 8.4 to 8.5 (job name, setup-php version, cache keys).
@pekral

pekral commented Jun 29, 2026

Copy link
Copy Markdown
Owner Author

Code Review — PR #727 (CI matrix 8.4 → 8.5)

Status: ✅ Converged — ready to merge
Counts: Critical 0 · Moderate 0 · Minor 0
Assignment conformance: no linked issue (self-directed infra fix discovered while merging #726).

Diff is a CI matrix version bump across .github/workflows/pr.yml and composer-update.yml (job name, setup-php version, cache keys) — no application code, no dependency change, no logic. CI now runs PHP 8.5 and the Quality Checks job is green (composer install resolves pekral/phpcs-rules dev-master's php ^8.5 requirement). No findings.

Checked for stray 8.4 references: CHANGELOG.md:59 is immutable release history (left as-is) and README.md:20 describes the PHP version the shipped guidelines target for consumer projects (a separate concern from this repo's own CI toolchain), so neither needs changing here.

Summary: assignment conformance: no linked issue. Minimal, correct CI-toolchain fix; no blocking findings.

@pekral
pekral marked this pull request as ready for review June 29, 2026 12:00
@pekral
pekral merged commit 3ee7e8c into master Jun 29, 2026
1 check passed
@pekral
pekral deleted the ci/php-85-matrix branch June 29, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant