ci: run quality checks on PHP 8.5 to match the tooling floor#727
Conversation
pekral/phpcs-rules dev-master now requires PHP ^8.5, so 'composer install' fails
on the PHP 8.4 CI matrix ('your php version (8.4.22) does not satisfy ^8.5'),
breaking every PR's Quality Checks job. The project declares no require.php and
all three first-party pekral/* tooling deps track dev-master, so the toolchain
floor is now 8.5 (local dev already runs 8.5). Bump both workflows' PHP matrix
from 8.4 to 8.5 (job name, setup-php version, cache keys).
Code Review — PR #727 (CI matrix 8.4 → 8.5)Status: ✅ Converged — ready to merge Diff is a CI matrix version bump across Checked for stray Summary: assignment conformance: no linked issue. Minimal, correct CI-toolchain fix; no blocking findings. |
Shrnutí
Opravuje repo-wide selhání CI.
pekral/phpcs-rulesnadev-masternově vyžaduje PHP^8.5, takžecomposer installna CI matici PHP 8.4 selže:To shazuje Quality Checks job u každého PR (objeveno při pokusu o merge #726). Projekt nemá
require.phpa všechny tři first-partypekral/*tooling závislosti jedou nadev-master, takže floor toolchainu je teď 8.5 (lokální dev už běží na 8.5).Co se mění
.github/workflows/pr.yml— PHP matrix 8.4 → 8.5 (název jobu,setup-php, cache klíče).github/workflows/composer-update.yml—setup-php8.4 → 8.5Jak testovat
CI tohoto PR běží na upraveném workflow (8.5) —
composer installprojde a Quality Checks musí být zelené.Odblokovává merge #726 a všech dalších PR.