fix(mac): CGDisplayStream fallback when SCShareableContent misses virtual display#143
Open
hmachine1999 wants to merge 1 commit into
Open
Conversation
On some Mac mini + external-display-only setups, CGVirtualDisplay creates successfully but the display never appears in SCShareableContent (MacSender Code=3). Connection and hello succeed, yet capture never starts — no purple indicator and the receiver stays on the OpenDisplay UI. - Wait briefly for the virtual display to attach after applySettings - Improve findSCDisplay diagnostics and size-based matching - If SCK still cannot enumerate the display, capture via CGDisplayStream using the known CGDirectDisplayID (deprecated API, fallback only) Fixes the user-visible dead-end for peetzweg#142.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the hard failure path reported in #142:
On affected machines (reproduced: Mac mini M2 + single external 4K display + macOS 15.7.x):
phone hellosucceedCGVirtualDisplayis created and returns an idSCShareableContentnever lists that id → capture never startsThis is not a network failure — enumeration fails after a successful handshake.
Changes
Mac/VirtualDisplay.swiftwaitUntilReady()— poll online/NSScreenafterapplySettings(async)Mac/MacSender.swiftfindSCDisplay(explicit SCK API, size match, diagnostic logs)Mac/MacSender.swiftCGDirectDisplayIDMac/MacSender.swiftdisplayStreaminstop()/reconfigure()ScreenCaptureKit remains the preferred path. CGDisplayStream is deprecated and used only as a last resort so users are not stuck with Code=3 when the virtual display id is already known.
Test plan
OpenSidecarMac)/tmp/opensidecar-mac.logshows either normalcapture started:orcapture started (CGDisplayStream fallback):Notes / non-goals
Closes #142