fix!: align EntriesTextsMode with getEntriesTextsV3 API#353
Merged
Conversation
Replace legacy search mode values with add, edit, and reports, and require mode on getEntriesTexts and getEntriesTextsPage. Fixes #351
commit: |
Coverage Report for CI Build 26346953949Coverage decreased (-0.02%) to 77.463%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EntriesTextsModeto match the v3 API (add,edit,reports) instead of legacy search modes (exact_match,starts_with, etc.)modea required parameter ongetEntriesTexts()andgetEntriesTextsPage()Fixes #351
Test plan
npm testpasses locallygetEntriesTexts({ term, mode: EntriesTextsMode.Add })against a Clockodo accountBreaking change
Callers must pass
modeand migrate from removed enum members (ExactMatch,StartsWith,EndsWith,Contains) toAdd,Edit, orReports.