add flag/envvar to choose temp directory#867
Open
nyetsche wants to merge 1 commit into
Open
Conversation
the `sync` command uses `"github.com/lanrat/extsort"` to create a temporary directory (and files) for computing what to copy this PR adds a command line flag (& equivalent environment variable) to control where the directory is created. without it set, you always get the "intelligent choice", such as `/tmp`, but users have plenty of reasons to choose a different directory (`/tmp` too small, faster location that `extsort` didn't notice, etc.) Ref: https://github.com/lanrat/extsort#temporary-directory-selection example usage: ``` s5cmd sync --sort-temp-dir=/scratch FILE s3://[somewhere]/FILE ``` or ``` export S5CMD_SORT_TEMP_DIR=/scratch s5cmd sync FILE s3://[somewhere]/FILE ```
nyetsche
requested review from
ilkinulas and
sonmezonur
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
synccommand uses"github.com/lanrat/extsort"to create a temporary directory (and files) for computing what to copythis PR adds a command line flag (& equivalent environment variable) to control where the directory is created. without it set, you always get the "intelligent choice", such as
/tmp, but users have plenty of reasons to choose a different directory (/tmptoo small, faster location thatextsortdidn't notice, etc.)Ref: https://github.com/lanrat/extsort#temporary-directory-selection
example usage:
or