FIX: ctrlenv PYDM_DISPLAYS_PATH#344
Merged
Merged
Conversation
…deployed screens.
vespos
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set up the previously forgotten
PYDM_DISPLAYS_PATHinctrlenv_setup.shThis will point first to our released screens area, and then second to the dev screens area.
Motivation and Context
We had some screens previously that relied on this environment variable being set in order to locate some displays to embed in the screen.
One example is the KFE vacuum screen: https://github.com/pcdshub/lcls-pydm-vacuum/blob/62ca8dfbe53e60467e46121ba589ff8ab3116a2a/screens/sxrVac.ui#L1168
For context, here's how it was set up previously for
dev_condaandpcds_conda:engineering_tools/scripts/shared_conda_setup.sh
Line 116 in 184a6fa
Compared to before, I have:
common/v1.0.0/screen_name.uias a versioned embedded display. (It also seemed strange to me that only the dev directory had path support here).How Has This Been Tested?
I made sure the KFE vacuum screen opened correctly with this environment variable set. (Previously, it opened up with errors)
Where Has This Been Documented?
Here only