adding logic for tc motor - #341
Conversation
| # caget will return exit code 0 if :PLC:nErrorId_RBV exists, | ||
| # we set isbeckhoff based on this. | ||
| if caget "${PREFIX}:PLC:nErrorId_RBV" > /dev/null 2>&1; then | ||
| if [[ "${rtyp}" == 'tcmotor' ]] || caget "${PREFIX}:PLC:nErrorId_RBV" > /dev/null 2>&1; then |
There was a problem hiding this comment.
Did you make sure this still works for non tcmotor beckhoff motors?
There was a problem hiding this comment.
Yeah, regular IMS motors still work; I haven't tested on Aerotech yet. I'm not sure if we still use them.
There was a problem hiding this comment.
I don't mean to ask you to test every motor type, just the ones affected by this line: motors on beckhoff IOCs that aren't tcmotor type
There was a problem hiding this comment.
Yeah, I wanted to check Aerotech becuase I see the beckhoff logic is close the Aerotech. But it still works
There was a problem hiding this comment.
Ah yeah I see now that aerotech is the else clause here- didn't see it on review because it was outside the diff. Good job being thorough.
There was a problem hiding this comment.
But yeah I'll approve this if you can confirm that "old" beckhoff motors still work
There was a problem hiding this comment.
Yep! Tc motors with the RTYP as 'motor' still work.
2 participants
Description
Added support for beckhoff motors with the RTYP as tcmotor.
Motivation and Context
The user motors pvs have this value
How Has This Been Tested?
I tested on my checkout.
Where Has This Been Documented?