Skip to content

Remove Duplicated Code#118

Closed
ZeterTheDuck wants to merge 3 commits into
pbu-projects:mainfrom
ZeterTheDuck:madsen/remove-duplicated-code
Closed

Remove Duplicated Code#118
ZeterTheDuck wants to merge 3 commits into
pbu-projects:mainfrom
ZeterTheDuck:madsen/remove-duplicated-code

Conversation

@ZeterTheDuck

Copy link
Copy Markdown
Contributor

Affects the following:

  • Attachment.java: extends AttachmentBase
  • TicketAuditVia: deleted, use TicketVia instead
  • TicketCreateInput: extends TicketUpdateInput

…ketVia, which has more code.

TicketComment references TicketVia instead of TicketAuditVia
Attachment is just AttachmentBase with support for thumbnails. Remove AttachmentThumbnails as it is redundant.
TicketCreateInput now extends TicketUpdateInput
@Jonathan-Zollinger

Copy link
Copy Markdown
Contributor

I'll hold off on merging this PR until I setup a remedy for the 429 errors we're getting. shouldn't be more than a day or two

@ZeterTheDuck

Copy link
Copy Markdown
Contributor Author

Closing pull request, as #119 is more updated and is from the JustServe-Resources fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants