Skip to content

Fix mrsv lint warnings#1744

Open
benalleng wants to merge 1 commit into
payjoin:masterfrom
benalleng:msrv-lint-warnings
Open

Fix mrsv lint warnings#1744
benalleng wants to merge 1 commit into
payjoin:masterfrom
benalleng:msrv-lint-warnings

Conversation

@benalleng

Copy link
Copy Markdown
Collaborator

Closes #1743

This is less impactful than I first thought in the issue since the SessionContext is a private field

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 29440365541

Coverage increased (+0.001%) to 86.188%

Details

  • Coverage increased (+0.001%) from the base build.
  • Patch coverage: 39 of 39 lines across 2 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15964
Covered Lines: 13759
Line Coverage: 86.19%
Coverage Strength: 345.22 hits per line

💛 - Coveralls

@caarloshenriq caarloshenriq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should we care about msrv lint warnings for 1.0?

3 participants