Skip to content

Remove stale incompatible_msrv clippy allows#1742

Merged
spacebear21 merged 1 commit into
payjoin:masterfrom
xstoicunicornx:remove-clippy-allow
Jul 15, 2026
Merged

Remove stale incompatible_msrv clippy allows#1742
spacebear21 merged 1 commit into
payjoin:masterfrom
xstoicunicornx:remove-clippy-allow

Conversation

@xstoicunicornx

Copy link
Copy Markdown
Collaborator

Clippy no longer flags tokio::select! under the 1.85 MSRV, so the allow attributes in the v1 and v2 send/receive functions are dead. Verified clippy passes with -D warnings under --all-features and each of the v1/v2 feature sets alone.

This is a followup from #1737 (comment).

Claude Fable was used to put together this PR.

Pull Request Checklist

Please confirm the following before requesting review:

Clippy no longer flags tokio::select! under the 1.85 MSRV, so
the allow attributes in the v1 and v2 send/receive functions
are dead. Verified clippy passes with -D warnings under
--all-features and each of the v1/v2 feature sets alone.
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 29430315816

Coverage remained the same at 86.187%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15963
Covered Lines: 13758
Line Coverage: 86.19%
Coverage Strength: 345.34 hits per line

💛 - Coveralls

@spacebear21 spacebear21 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@spacebear21 spacebear21 merged commit 1da296b into payjoin:master Jul 15, 2026
13 checks passed
@xstoicunicornx xstoicunicornx deleted the remove-clippy-allow branch July 15, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants