Rename PersistedError::error_state to fatal_state#1728
Merged
Conversation
The method returns the state carried by a fatal rejection, mirroring transient_state for transient ones. Name it after the error class it applies to so the pairing is clear at the call site.
Collaborator
Coverage Report for CI Build 29125015849Coverage remained the same at 86.01%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method returns the state carried by a fatal rejection, mirroring transient_state for transient ones. Name it after the error class it applies to so the pairing is clear at the call site.
This is a follow up I suggested from #1724 (comment), feel free to close if not taking.
Claude Fable was used to generate these updates.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.