Skip to content

Rename PersistedError::error_state to fatal_state#1728

Merged
spacebear21 merged 1 commit into
payjoin:masterfrom
xstoicunicornx:rename-error_state
Jul 13, 2026
Merged

Rename PersistedError::error_state to fatal_state#1728
spacebear21 merged 1 commit into
payjoin:masterfrom
xstoicunicornx:rename-error_state

Conversation

@xstoicunicornx

Copy link
Copy Markdown
Collaborator

The method returns the state carried by a fatal rejection, mirroring transient_state for transient ones. Name it after the error class it applies to so the pairing is clear at the call site.

This is a follow up I suggested from #1724 (comment), feel free to close if not taking.

Claude Fable was used to generate these updates.

Pull Request Checklist

Please confirm the following before requesting review:

The method returns the state carried by a fatal rejection, mirroring
transient_state for transient ones. Name it after the error class it
applies to so the pairing is clear at the call site.
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 29125015849

Coverage remained the same at 86.01%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 1 uncovered change across 1 file (5 of 6 lines covered, 83.33%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
payjoin-cli/src/app/v2/mod.rs 1 0 0.0%
Total (3 files) 6 5 83.33%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15876
Covered Lines: 13655
Line Coverage: 86.01%
Coverage Strength: 343.76 hits per line

💛 - Coveralls

@spacebear21 spacebear21 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept ACK

@caarloshenriq caarloshenriq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 199b96e

@spacebear21 spacebear21 merged commit 7872a96 into payjoin:master Jul 13, 2026
13 checks passed
@xstoicunicornx xstoicunicornx deleted the rename-error_state branch July 14, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants