Use the binary dotnet SDK on all platforms#1725
Merged
benalleng merged 1 commit intoJul 10, 2026
Merged
Conversation
The Darwin-only conditional from payjoin#1723 assumed hydra serves the source-built VMR SDK from cache on Linux. It does not on the pinned nixpkgs rev: CI logs show ubuntu-latest fetching the 1xx binary SDK only to bootstrap a from-source dotnet-vmr-10.0.301 build that takes ~25 minutes, while the tests themselves finish in under a minute. Nothing is cached between runs, so every pull request pays the rebuild. Drop the conditional and use the Microsoft-binary SDK everywhere. This also insulates the dev shells from future nixpkgs bumps landing on VMR revisions hydra has not built yet.
Collaborator
Coverage Report for CI Build 29105296731Coverage remained the same at 86.003%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1723, which switched the Darwin dev shells to the Microsoft-binary .NET SDK on the assumption that Linux was fine because hydra serves the source-built SDK from the public cache. CI logs show that the assumption doesn't hold on the pinned nixpkgs rev.
The ubuntu-latest csharp job consistently takes ~30 minutes (29–33 min across recent runs).