Correct create_error_request return type#1715
Merged
Merged
Conversation
xstoicunicornx
force-pushed
the
fix-error-type
branch
from
7d8516a to
34dbbdb
Compare
Collaborator
Coverage Report for CI Build 29038187899Coverage decreased (-0.02%) to 85.986%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions6 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
spacebear21
previously approved these changes
Jul 9, 2026
spacebear21
left a comment
spacebear21
left a comment
Collaborator
There was a problem hiding this comment.
ACK, minor style comment left below
| reply_key, | ||
| ) | ||
| .map_err(InternalSessionError::Hpke)? | ||
| .map_err(InternalCreateRequestError::Hpke)? |
Collaborator
There was a problem hiding this comment.
nit: this should work because From is implemented for CreateRequestError.
Suggested change
| .map_err(InternalCreateRequestError::Hpke)? | |
| ? |
xstoicunicornx
force-pushed
the
fix-error-type
branch
from
34dbbdb to
267d640
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1714.
Receiver<HasReplyableError>::create_error_requestis currently employing aSessionErrorerror type when it should be usingCreateRequestErrorerror type instead, just like all the create request methods. This PR makes that correction.Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.