Skip to content

Fix build/compile breakage across example projects (DOC-1995) - #46

Merged
Elijah Skeirik (payablijah) merged 2 commits into
mainfrom
elijah/doc-1995-code-maintenance
Aug 10, 2026
Merged

Fix build/compile breakage across example projects (DOC-1995)#46
Elijah Skeirik (payablijah) merged 2 commits into
mainfrom
elijah/doc-1995-code-maintenance

Conversation

@payablijah

Copy link
Copy Markdown
Collaborator

Summary

Maintenance pass over every example project in the repo (DOC-1995) — installed/built/compiled all 21 SDK, webhook, and framework-integration examples to find real gaps, not just style nits. Fixed the ones that actually break for a fresh clone or fail type-checking:

  • sdk/go-sdk: go build failed on a fresh clone with missing go.sum entry errors because sdk/go-sdk/.gitignore explicitly excluded go.sum. Removed that line and committed a working go.sum.
  • webhooks/php-sdk: composer install failed outright (exit 4) — composer.lock was pinned to payabli/payabli 1.0.1, which doesn't satisfy the ^1.0.8 constraint in composer.json. Ran composer update to fix; this also cleared 11 security advisories on a transitively-pinned old guzzlehttp/guzzle.
  • webhooks/ts-sdk: tsc failed — eventType: "ApprovedPayment" no longer matches the current @payabli/sdk-node types, which expect the lowercase literal "approvedpayment". Fixed the casing.
  • react-native: tsc --noEmit failed on PayabliEmbeddedWebView.tsx with a WebView prop-type overload error. Root cause was react-native itself being two patch versions behind what the installed Expo SDK (57.0.12) expects (0.86.0 vs 0.86.2), not react-native-webview. Bumped via expo install --fix; confirmed expo export --platform web still bundles correctly.
  • vue-integration: package.json name field was react-embedded-demo, copy-pasted from react-integration. Fixed to vue-embedded-demo.

Every other example (boarding, temp-token, react-integration, sdk/ts-sdk, sdk/cs-sdk, webhooks/cs-sdk, sdk & webhooks go/java/php/py/ruby/rust) installed and built/compiled cleanly with no changes needed.

Test plan

  • sdk/go-sdk: go build ./... succeeds on a clean checkout
  • webhooks/php-sdk: composer install succeeds, composer audit reports no advisories
  • webhooks/ts-sdk: tsc --noEmit passes
  • react-native: tsc --noEmit passes, expo export --platform web bundles successfully
  • vue-integration: pnpm build still succeeds after the name change
  • All other 16 example projects re-verified to install/build/compile without changes

🤖 Generated with Claude Code

- sdk/go-sdk: stop gitignoring go.sum so `go build` works on a fresh
  clone instead of failing with missing go.sum entries
- webhooks/php-sdk: update stale composer.lock to satisfy the
  payabli/payabli ^1.0.8 constraint (was locked to 1.0.1, which also
  pulled in a vulnerable guzzlehttp/guzzle transitively)
- webhooks/ts-sdk: fix eventType casing ("ApprovedPayment" ->
  "approvedpayment") to match the current @payabli/sdk-node types
- vue-integration: fix package.json name copy-pasted from
  react-integration

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
react-native was pinned at 0.86.0, two patches behind what Expo SDK
57.0.12 expects (0.86.2), which caused react-native-webview's WebView
component to fail tsc's overload resolution ("props: never"). Bumping
react-native-webview alone didn't fix it; aligning react-native via
`expo install --fix` did. Confirmed `expo export --platform web` still
bundles correctly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes build and type-check failures across several SDK and framework examples.

Changes:

  • Adds Go dependency checksums and tracks go.sum.
  • Refreshes PHP dependencies and corrects the TypeScript webhook event literal.
  • Aligns React Native with Expo and corrects Vue package metadata.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/go-sdk/.gitignore Allows go.sum tracking.
sdk/go-sdk/go.sum Adds dependency checksums.
webhooks/php-sdk/composer.lock Updates incompatible and vulnerable dependencies.
webhooks/ts-sdk/main.ts Uses the SDK-compatible event literal.
react-native/package.json Aligns React Native with Expo SDK 57.
vue-integration/package.json Corrects the Vue package name.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@payablijah
Elijah Skeirik (payablijah) merged commit 4159d82 into main Aug 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants