Fix startup crash: missing icon resources (NPE in GUI.start) - #28
Open
overcuriousity wants to merge 1 commit into
Open
Fix startup crash: missing icon resources (NPE in GUI.start)#28overcuriousity wants to merge 1 commit into
overcuriousity wants to merge 1 commit into
Conversation
Version 5.0 crashes at launch with a NullPointerException in GUI.start (GUI.java:578): the toolbar loads /icon24_lighthouse.png, which does not exist in the resources folder. Three more lookups were broken the same way and would crash as soon as a database is opened or the Lighthouse map is shown: - /icon24_lighthouse.png (toolbar): never existed; use the existing icon24_location.png, which belongs to the same cell-tower feature. - /gray_database24.png (db tree node): was deleted in the 4.1 cleanup; restored from git history (commit 468cf09). - /journal-icon.png (journal tree node): was deleted in the 4.21 cleanup (682be07); restored from git history. - /gray_archive24.png (WAL tree node): never existed; use the existing wal-icon.png instead. - /lighthouse_logo.png (map splash screen): never existed; the splash is now skipped gracefully when the artwork is absent instead of throwing from Objects.requireNonNull. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FQLite 5.0 crashes immediately on launch (tested with a Linux jpackage build):
Line 578 loads
/icon24_lighthouse.png, which is not present inresources/. A sweep over allgetResource/getResourceAsStreamcalls insrcfound four more lookups pointing at files missing fromresources/— those crash as soon as a database is opened (tree node icons) or the Lighthouse map is shown (splash).Fixes
icon24_lighthouse.png(toolbar, GUI.java:578)icon24_location.png(same cell-tower feature)gray_database24.png(db tree node)d687b12)468cf09)journal-icon.png(journal tree node)682be07)gray_archive24.png(WAL tree node)wal-icon.pnglighthouse_logo.png(map splash)If original lighthouse artwork exists somewhere outside the repo, adding
icon24_lighthouse.png/lighthouse_logo.pngtoresources/would of course also work — this PR just makes the app run with what the repo contains.Independent of #27 (RPM packaging), but found while testing the RPM from that branch.
🤖 Generated with Claude Code