bridge: fix unwanted duplicated IRC channels on auto-join#9
Merged
Conversation
Have a matrix account configured to be in a multiple matrix rooms, some (but not all) rooms show up as multiple IRC channels after connecting to the IRC server with a client. It seems this happens for rooms with multiple published addresses: in this case each published address is mapped to an IRC channel, which is an unwanted duplication. This happens because chan_to_room container is used to produce the list of IRC channels to auto-join, which has one entry per published address. Fix the problem by iterating room_to_chan instead, which gives us exactly one IRC channel per matrix room, even if the room has multiple published addresses. Also add a test that covers the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have a matrix account configured to be in a multiple matrix rooms, some (but not all) rooms show up as multiple IRC channels after connecting to the IRC server with a client.
It seems this happens for rooms with multiple published addresses: in this case each published address is mapped to an IRC channel, which is an unwanted duplication. This happens because chan_to_room container is used to produce the list of IRC channels to auto-join, which has one entry per published address.
Fix the problem by iterating room_to_chan instead, which gives us exactly one IRC channel per matrix room, even if the room has multiple published addresses.
Also add a test that covers the fix.