weechat, show msgid: handle CTCP ACTION (/me) messages#11
Merged
Conversation
The "[msgid] " prefix was correctly inserted for plain messages, but not for /me style messages. Instead we got "[...] ^AACTION ...^A". This happens because CTCP messages have an additional prefix before their body, and the naive prefixing broke that. Fix the problem by explicitly checking for ^AACTION as a prefix and insert the msgid after that, so the result is like "* NICK [...] BODY". Do this only for ACTION, till we run into an other type for CTCP message that wants this; msgid_rewrite_irc_action() in the irssi script is also specific to ACTION.
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "[msgid] " prefix was correctly inserted for plain messages, but not for /me style messages. Instead we got "[...] ^AACTION ...^A".
This happens because CTCP messages have an additional prefix before their body, and the naive prefixing broke that.
Fix the problem by explicitly checking for ^AACTION as a prefix and insert the msgid after that, so the result is like "* NICK [...] BODY".
Do this only for ACTION, till we run into an other type for CTCP message that wants this; msgid_rewrite_irc_action() in the irssi script is also specific to ACTION.