Merge development into main#59
Merged
Merged
Conversation
patrickschaper
commented
May 20, 2026
patrickschaper
commented
Owner
- fix: workflow permissions for code scanning alert
- feat: update character size range and default
- remove sizes with width < 8px (dropped 4×8 through 7×13) - add sizes up to 24px wide (added 19×36 through 24×46) - change default from 11×21 to 16×30 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Remove sizes with width < 8px (dropped 4×8 through 7×13) - Add sizes up to 24px wide (added 19×36 through 24×46) - Change default from 11×21 to 16×30
…aver into development
Back-merges release commits from `main` into `development` to keep branches in sync.
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…n permissions (#57) Potential fix for [https://github.com/patrickschaper/matrixScreenSaver/security/code-scanning/1](https://github.com/patrickschaper/matrixScreenSaver/security/code-scanning/1) Add an explicit `permissions` block at the workflow root so all jobs inherit least-privilege defaults. For this workflow, the minimal safe setting is: - `contents: read` This preserves current behavior (the job only evaluates branch name and exits success/failure) while ensuring the token cannot gain broader permissions via repo/org defaults now or later. **Where to change:** `.github/workflows/branch-policy.yml`, directly after the workflow `name` (before `on:`). No new imports, methods, or dependencies are required. _Suggested fixes powered by Copilot Autofix. Review carefully before merging._
Each physical display gets a unique animation because NativeMatrixRenderer now XORs a seedOffset (derived from CGDirectDisplayID via NSScreenNumber) into sceneSeed inside beginSceneSequence(). Previously all screens shared the same quantised-time seed, producing identical rain on every display. The macOS ScreenSaver framework already instantiates one ScreenSaverView per connected display; this change makes each instance animate independently. Includes TDD tests (tests.sh) covering seed determinism and per-display divergence. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- document use of /// doc comments for types, properties, and methods - add Parameters, Returns, and Throws block guidelines - add MARK: - section separator guidance - note to comment why not what, skip self-evident code Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- split tests into Xorshift64Tests.swift and NativeMatrixRendererTests.swift - rewrite test runner to emit TAP output (Test Anything Protocol) - extract MatrixRendererLimits.swift for Foundation-only validation constants - add .github/workflows/tests.yml to run tests on macOS CI - add Test section to README - update build.sh and tests.sh for new file layout Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- add repository layout tables for source, tests, scripts, workflows - document TAP test format and how to add new testable source files - add Build and Tests sections with commands - note MatrixRendererLimits Foundation-only constraint - add development as default PR branch - include test: conventional commit type Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…58) Each physical display gets a unique animation because `NativeMatrixRenderer` now XORs a `seedOffset` (derived from `CGDirectDisplayID` via `NSScreenNumber`) into `sceneSeed` inside `beginSceneSequence()`. Previously all screens shared the same quantised-time seed, producing identical rain on every display. The macOS ScreenSaver framework already instantiates one `ScreenSaverView` per connected display; this change makes each instance animate independently. - add `seedOffset` property to `NativeMatrixRenderer` - derive seed from `NSScreenNumber` in `MatrixScreenSaverView` - extract `MatrixRendererLimits.swift` for Foundation-only validation constants - add TAP test suite with `Xorshift64Tests` and `NativeMatrixRendererTests` - add CI workflow (`tests.yml`) running `./tests.sh` on `macos-latest` - add Test section to README and update AGENTS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.