add debug statements and check add backup patches if they weren't tested#577
Merged
Merged
Conversation
ewlu
force-pushed
the
ewlu/update-precommit-patch-checking
branch
from
9194785 to
41812c9
Compare
ewlu
force-pushed
the
ewlu/update-precommit-patch-checking
branch
from
38ad71e to
7d0bffb
Compare
patrick-rivos
approved these changes
Aug 5, 2025
patrick-rivos
left a comment
patrick-rivos
left a comment
Owner
There was a problem hiding this comment.
LGTM but lets keep an eye on it and see if we can root cause this and remove the backup runner since that could technically be a race if the old run gets delayed far enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches were getting skipped sometimes where the patch did not show up in the expected start --> end time frame, but were showing up in the backup --> start timeframe. Add more debug statements to better identify this situation and also run patches in the backup --> start timeframe if they were not ran before. This can be done through the patchwork-api/patch_id/checks endpoint