Add toggle for Fever style scoring#20
Open
viviancherry9 wants to merge 7 commits into
Open
Conversation
the skillstar category now distributes its points and amtInputs amongst the other categories
patataofcourse
requested changes
Apr 11, 2026
renamed scoringFunctionPos to scoringHookPos, changed do while loops to for loops replaced NO_PTR with UNIMPLEMENTED
patataofcourse
approved these changes
May 22, 2026
| return RegionMegamix::UNK; | ||
| } | ||
|
|
||
| int decideFinalScore(Megamix::CResultManager *arg1) { |
Owner
There was a problem hiding this comment.
still think arg1 should be self instead
| .dataEnd= 0x54f16c, | ||
| .bssEnd= 0x5dc2f0, | ||
|
|
||
| .scoringHookPos= GameInterface::UNIMPLEMENTED, |
Owner
There was a problem hiding this comment.
this is less urgent, but support for EU and KR would be heavily appreciated (and probably doesn't require that much work)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code for this feature is fully implemented, but there is currently no toggle. It is on by default.