Skip to content

Fix: assistant history always null due to mismatched JSON field key in buildConversationContext #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: feature/agent-migration-improvements
Choose a base branch
from
Open

Fix: assistant history always null due to mismatched JSON field key in buildConversationContext #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c471ad2
Initial plan
Copilot Mar 12, 2026
b65bafb
fix: read agentOutput field in buildConversationContext to match Sess…
Copilot Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...rity-supervisor-agent/src/main/java/com/agent/service/SecuritySupervisorAgentService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,8 @@ private int countJsonArray(String json) {

/**
* Build ConversationContext from Redis session history.
* Each history entry is a JSON string of {userQuery, agentSummary, timestamp}.
* Each history entry is a JSON string of {userQuery, agentOutput, timestamp},
* as persisted by {@link SessionStore#saveChatEntry}.
* If history is empty or an error occurs, returns an empty context.
*/
private ConversationContext buildConversationContext(String sessionId, String currentQuery) {
Expand All @@ -280,7 +281,7 @@ private ConversationContext buildConversationContext(String sessionId, String cu
try {
com.fasterxml.jackson.databind.JsonNode node = objectMapper.readTree(entry);
String query = node.path("userQuery").asText(null);
String summary = node.path("agentSummary").asText(null);
String summary = node.path("agentOutput").asText(null);
String ts = node.path("timestamp").asText(Instant.now().toString());
if (query != null) {
messages.add(new ConversationContext.ChatMessage(query, summary, ts));
Expand Down