feat: Add FCM analytics label support#569
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
📝 WalkthroughWalkthroughThis PR adds analytics label support to the Parse Server push adapter's FCM implementation. The change enables developers to include an ChangesFCM Analytics Label Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I will reformat the title to use the proper commit message syntax. |
|
Ready for review. I kept the PR focused on FCM analytics label support, added validation coverage, and verified locally with eslint plus the focused Jasmine/c8 suite. The full npm test script is not Windows-shell compatible locally because it uses POSIX env assignment syntax, so I validated the same underlying checks directly. |
Fixes #377
Summary
analytics_label/analyticsLabelin FCM push data and validate it against Firebase's analytics-label-safe character set and length.fcmOptions.analyticsLabelfor Android and APNS-over-FCM payloads.Verification
npx eslint src/FCM.js spec/FCM.spec.js$env:TESTING='1'; npx c8 ./node_modules/.bin/jasmine(167 specs passing)Summary by CodeRabbit
New Features
Documentation