chore: add rel="noopener noreferrer" to the external _blank link#125
Open
kirushik wants to merge 1 commit into
Open
chore: add rel="noopener noreferrer" to the external _blank link#125kirushik wants to merge 1 commit into
kirushik wants to merge 1 commit into
Conversation
The Wikipedia link in GeneralInfo.vue opened in a new tab without `rel`, leaving it exposed to reverse-tabnabbing. Negligible in practice (offline use, trusted URL) but free hygiene. It is the only target="_blank" link in the app; the other external links open in the same tab. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds rel="noopener noreferrer" to an external link to improve security and follow best practices for target="_blank" links.
Changes:
- Reformats the anchor tag onto multiple lines for readability
- Adds
rel="noopener noreferrer"attribute to the external Wikipedia link
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Wikipedia link in
GeneralInfo.vueopened in a new tab withoutrel, leaving it exposed to reverse tabnabbing.Negligible in practice (offline use, trusted URL) but free hygiene.
It is the only
target="_blank"link in the app; the other external links open in the same tab.